[editor] JSON Renderer for Model Settings #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rholinshead
requested review from
saqadri,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
rossdanlm
reviewed
Jan 5, 2024
| {schema && ( | ||
| <Flex justify="flex-end"> | ||
| <Tooltip label="Toggle JSON editor" withArrow> | ||
| <ActionIcon onClick={() => setIsRawJSON((curr) => !curr)}> |
rossdanlm
reviewed
Jan 5, 2024
| onChange={(val) => | ||
| onUpdateModelSettings(val as Record<string, unknown>) | ||
| } | ||
| // schema={schema} TODO: Add schema after fixing z-index issue |
There was a problem hiding this comment.
The editor tooltips have lower z-index than the surrounding elements so they're hidden. Just need to look into it and bump it
rossdanlm
approved these changes
Jan 5, 2024
rholinshead
added a commit
that referenced
this pull request
Jan 5, 2024
) # [editor][easy] Remove Unused ModelSettingsConfigRenderer Component Component unused (as of #757) and can be removed. ## Testing: - loaded the editor settings without issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[editor] JSON Renderer for Model Settings
Set up the JSON Editor for model settings, allowing toggling between the schema-backed UI if the schema is available or defaulting to the JSON editor if no schema is available.
No Schema, JSONEditor Only:
With Schema, Toggle Between:
Screen.Recording.2024-01-04.at.4.50.30.PM.mov