[editor] Move Demo Editor travel.aiconfig.json to editor dir #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rholinshead
commented
Dec 26, 2023
| @@ -10,9 +10,7 @@ export default function Editor() { | |||
| const [aiconfig, setAiConfig] = useState<ClientAIConfig | undefined>(); | |||
|
|
|||
| const loadConfig = useCallback(async () => { | |||
| const res = await ufetch.post(ROUTE_TABLE.LOAD, { | |||
| path: "cli/aiconfig-editor/travel.aiconfig.json", | |||
There was a problem hiding this comment.
path is no longer needed with recent update to /load
rholinshead
requested review from
saqadri,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
saqadri
approved these changes
Dec 26, 2023
rholinshead
added a commit
that referenced
this pull request
Dec 26, 2023
…622) # [editor] Remove /cli Editor in Favour of Python-server-backed Editor The python-server-backed local editor is in good enough shape for all dev work, so remove the /cli dir to avoid any confusion around which files to use (also, removes duplicates from searches) `aiconfig edit --aiconfig-path=python/src/aiconfig/editor/travel.aiconfig.json --server-mode='debug_servers'` and ensure the editor works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/622). * __->__ #622 * #623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[editor] Move Demo Editor travel.aiconfig.json to editor dir
This test config is being removed from under the
/clidir in #622 where the entire/clidir is being removed. So, move the file here to use for testingTesting:
aiconfig edit --aiconfig-path=python/src/aiconfig/editor/travel.aiconfig.json --server-mode='debug_servers'correctly loads the editorStack created with Sapling. Best reviewed with ReviewStack.