[editor] Fix Client Request API Endpoint to Work for Any Prod Port #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rholinshead
requested review from
saqadri,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
saqadri
approved these changes
Dec 26, 2023
Ankush-lastmile
added a commit
that referenced
this pull request
Dec 26, 2023
…ifying port (#624) [editor] Functionality to run server on multiple configs without specifying port ## What: Before creating the server process, check if the port to be used is taken. If so, find the next available one before continuing for context: this builds on top of #619 ## Why When running the editor, user should be able to open multiple configs. Under the hood this means spinning up another server in an unused port. Frontend already supports dynamic ports. ## Testplan 1. yarn build in aiconfig/python/src/aiconfig/editor/client 2. Open two aiconfigs with "prod" editor" | Getting Started aiconfig | Chain Of Verification aiconfig| |------------|-------------| |  | | |  | | Terminals showcase the command used to open editor. Each one has a seperate config file path. No port is passed in from the user. Chain of verification Uses Port 8080 Getting Started in a new process using Port 8081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[editor] Fix Client Request API Endpoint to Work for Any Prod Port
In development, the client will be served via a node process from
react-scriptsat localhost:3000 by default. The python server will be at localhost:8080 by default.In 'prod', the client will be bundled and statically served by the python server at the same port as the python server.
So, for prod we should make requests to '/api/*' which will resolve to the hostname/port of the server that served the JS.
For dev, we can just hardcode to the correct server port for now.
Testing:
yarn buildinaiconfig/python/src/aiconfig/editor/clientThen run the prod server mode:
aiconfig edit --aiconfig-path=cli/aiconfig-editor/travel.aiconfig.json --server-mode='prod'and see the editor at localhost:8080 sending correct requests
Simultaneously, start up on another port:
ryanholinshead@Ryans-MacBook-Pro aiconfig % aiconfig edit --aiconfig-path=cli/aiconfig-editor/travel.aiconfig.json --server-mode='prod' --server-port=1234and see the editor there as well