[easy][ts] 2/n Set run output type to be Output[] instead of Union #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
force-pushed
the
pr618
branch
2 times, most recently
from
83d63eb to
7ef27c8
Compare
Ankush-lastmile
commented
Dec 26, 2023
| @@ -398,7 +398,7 @@ export class AIConfigRuntime implements AIConfig { | |||
| promptName: string, | |||
| params: JSONObject = {}, | |||
| options?: InferenceOptions | |||
| ) { | |||
| ): Promise<Output[]> { | |||
There was a problem hiding this comment.
line 430 below guarantees the output of run() is an array of outputs
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
saqadri
approved these changes
Dec 26, 2023
Ankush-lastmile
added a commit
that referenced
this pull request
Dec 26, 2023
…617) [eng week] Set run output type to be list[Output] instead of Output This diff is the same as #343, rebased onto main. Sapling decided to create a new pr. Makes it more scalable. The Prompt schema already refers to `outputs` as `List[Output]` anyways --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/617). * #618 * __->__ #617
added 2 commits
December 27, 2023 18:17
This diff is the same as #343, rebased onto main. Sapling decided to create a new pr. Makes it more scalable. The Prompt schema already refers to `outputs` as `List[Output]` anyways
## What Updating the types in the ts sdk to return `Output[]` instead of `Output | Output[]` ## Why Run method should always return a array of outputs, even if its just one output. The Prompt schema already refers to `outputs` as `outputs?: Output[];` anyways ## Testplan Ran tests without errors. No type errors on compilation either <img width="997" alt="Screenshot 2023-12-26 at 1 16 46 PM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/a5e3f16f-39e4-4325-95e1-6ac837daeab0">
Ankush-lastmile
force-pushed
the
pr618
branch
from
7ef27c8 to
c91d8bf
Compare
|
created #645 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[easy][ts] 2/n Set run output type to be Output[] instead of Union
What
Updating the types in the ts sdk to return
Output[]instead ofOutput | Output[]Why
Run method should always return a array of outputs, even if its just one output.
The Prompt schema already refers to
outputsasoutputs?: Output[];anywaysTestplan
Ran tests without errors. No type errors on compilation either
Stack created with Sapling. Best reviewed with ReviewStack.