Skip to content

Commit

Permalink
[aiconfig] Remove Duplicate GPT-4 Model from Default Registry (#761)
Browse files Browse the repository at this point in the history
# [aiconfig] Remove Duplicate GPT-4 Model from Default Registry

The default model parser registry was registering GPT-4 with capitals
and was only used in this example config used for testing. Let's just
fix that config to use "gpt-4" (lowercase) and remove the
duplicate/confusing capitalized model.

## Testing:
`pytest`
```
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================================================== 103 passed, 38 warnings in 1.59s =======================================================================================
```
  • Loading branch information
rholinshead authored Jan 5, 2024
2 parents 00b7acd + 189da6e commit ff81d7b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
1 change: 0 additions & 1 deletion python/src/aiconfig/Config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

gpt_models = [
"gpt-4",
"GPT-4",
"gpt-4-0314",
"gpt-4-0613",
"gpt-4-32k",
Expand Down
10 changes: 5 additions & 5 deletions python/tests/aiconfigs/GPT4 Coding Assistant_aiconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"input": "Refactor {{code_gen.output}} and add comments",
"metadata": {
"model": {
"name": "GPT-4",
"name": "gpt-4",
"settings": {
"model": "gpt-4",
"top_p": 1,
Expand All @@ -46,7 +46,7 @@
"input": "Refine {{refactor_cell.output}} to clean it up with proper error handling and add appropriate typing if applicable? If there is anything missing, explain and show the updated code.",
"metadata": {
"model": {
"name": "GPT-4",
"name": "gpt-4",
"settings": {
"model": "gpt-4",
"top_p": 1,
Expand All @@ -65,7 +65,7 @@
"input": "Convert from {{refine_code_cell.output}} into {{language}}. Maintain modern programming standards for that new language and equivalent standards of commenting, documentation. ",
"metadata": {
"model": {
"name": "GPT-4",
"name": "gpt-4",
"settings": {
"model": "gpt-4",
"top_p": 1,
Expand All @@ -81,7 +81,7 @@
"input": "Give me a concise explanation of what a function does. Use bullet points and headings so the summary is organized and readable. Here is the function: {{code}}",
"metadata": {
"model": {
"name": "GPT-4",
"name": "gpt-4",
"settings": {
"model": "gpt-4",
"top_p": 1,
Expand All @@ -97,7 +97,7 @@
"input": "{{code}}",
"metadata": {
"model": {
"name": "GPT-4",
"name": "gpt-4",
"settings": {
"model": "gpt-4",
"top_p": 1,
Expand Down

0 comments on commit ff81d7b

Please sign in to comment.