[easy][ts] 2/n Set run output type to be Output[] instead of Union (#618

) [easy][ts] 2/n Set run output type to be Output[] instead of Union ## What Updating the types in the ts sdk to return `Output[]` instead of `Output | Output[]` ## Why Run method should always return a array of outputs, even if its just one output. The Prompt schema already refers to `outputs` as `outputs?: Output[];` anyways ## Testplan Ran tests without errors. No type errors on compilation either <img width="997" alt="Screenshot 2023-12-26 at 1 16 46 PM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/a5e3f16f-39e4-4325-95e1-6ac837daeab0"> --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/618). * __->__ #618 * #617
lastmile-ai · Dec 27, 2023 · 9244ccb · 9244ccb
2 parents f35d6a4 + c91d8bf
commit 9244ccb
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/extensions/HuggingFace/typescript/hf.ts b/extensions/HuggingFace/typescript/hf.ts
@@ -185,7 +185,7 @@ export class HuggingFaceTextGenerationModelParserExtension extends Parameterized
     aiConfig: AIConfigRuntime,
     options?: InferenceOptions | undefined,
     params?: JSONObject | undefined
-  ): Promise<Output | Output[]> {
+  ): Promise<Output[]> {
     const startEvent = {
       name: "on_run_start",
       file: __filename,

diff --git a/extensions/llama/typescript/llama.ts b/extensions/llama/typescript/llama.ts
@@ -351,7 +351,7 @@ export class LlamaModelParser extends ParameterizedModelParser<LlamaCompletionPa
     aiConfig: AIConfigRuntime,
     options?: InferenceOptions | undefined,
     params?: JSONObject | undefined
-  ): Promise<Output | Output[]> {
+  ): Promise<Output[]> {
     const startEvent = {
       name: "on_run_start",
       file: __filename,

diff --git a/typescript/lib/config.ts b/typescript/lib/config.ts
@@ -398,7 +398,7 @@ export class AIConfigRuntime implements AIConfig {
     promptName: string,
     params: JSONObject = {},
     options?: InferenceOptions
-  ) {
+  ): Promise<Output[]> {
     const startEvent = {
       name: "on_run_start",
       file: __filename,
@@ -452,7 +452,7 @@ export class AIConfigRuntime implements AIConfig {
     promptName: string,
     params: JSONObject = {},
     options?: InferenceOptions
-  ) {
+  ): Promise<Output[] | undefined> {
     const prompt = this.getPrompt(promptName);
     if (!prompt) {
       throw new Error(

diff --git a/typescript/lib/modelParser.ts b/typescript/lib/modelParser.ts
@@ -89,7 +89,7 @@ export abstract class ModelParser<T = JSONObject, R = T> {
     aiConfig: AIConfigRuntime,
     options?: InferenceOptions,
     params?: JSONObject
-  ): Promise<Output | Output[]>;
+  ): Promise<Output[]>;
 
   /**
    * Get the string representing the output from a prompt.

diff --git a/typescript/lib/parameterizedModelParser.ts b/typescript/lib/parameterizedModelParser.ts
@@ -63,7 +63,7 @@ export abstract class ParameterizedModelParser<
     aiConfig: AIConfigRuntime,
     options?: InferenceOptions,
     params: JSONObject = {}
-  ) {
+  ): Promise<Output[] | undefined> {
     const dependencyGraph = getDependencyGraph(aiConfig);
 
     return await this.runWithDependenciesInternal(

diff --git a/typescript/lib/parsers/hf.ts b/typescript/lib/parsers/hf.ts
@@ -177,7 +177,7 @@ export class HuggingFaceTextGenerationParser extends ParameterizedModelParser<Te
     aiConfig: AIConfigRuntime,
     options?: InferenceOptions | undefined,
     params?: JSONObject | undefined
-  ): Promise<Output | Output[]> {
+  ): Promise<Output[]> {
     const startEvent = {
       name: "on_run_start",
       file: __filename,

diff --git a/typescript/lib/parsers/openai.ts b/typescript/lib/parsers/openai.ts
@@ -154,7 +154,7 @@ export class OpenAIModelParser extends ParameterizedModelParser<CompletionCreate
     aiConfig: AIConfigRuntime,
     options?: InferenceOptions,
     params?: JSONObject | undefined
-  ): Promise<Output | Output[]> {
+  ): Promise<Output[]> {
     if (!this.openai) {
       const apiKey = getAPIKeyFromEnv("OPENAI_API_KEY");
       this.openai = new OpenAI({ apiKey, ...(this.openaiOptions || {}) });
@@ -541,7 +541,7 @@ export class OpenAIChatModelParser extends ParameterizedModelParser<Chat.ChatCom
     aiConfig: AIConfigRuntime,
     options?: InferenceOptions,
     params?: JSONObject | undefined
-  ): Promise<Output | Output[]> {
+  ): Promise<Output[]> {
     const startEvent = {
       name: "on_run_start",
       file: __filename,