Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update port to Windows #23

Open
larryhastings opened this issue Jun 5, 2016 · 1 comment
Open

Update port to Windows #23

larryhastings opened this issue Jun 5, 2016 · 1 comment

Comments

@larryhastings
Copy link
Owner

I just redid the platform abstraction. I tried to keep the Windows port going, but I don't have a Windows box handy so I can't test it. Please test and fix!

@brianherman
Copy link

brianherman commented Jun 6, 2016

You have a section where you included unistd.h so i put in this to fix that, I'll try to give you a patch tomorrow but it is an easy fix.
Instead of just unistd.h you need:
#ifdef _WIN32
#include <io.h>
#else
#include <unistd.h>
#endif
But I am getting this error when I build: This error also happens for every file that is in \Python..

    c:\users\brian\desktop\gilectomy\include\lock.h(210): warning C4013: 'pthread_equal' undefined;     assuming extern returning int [C:\Users\brian\Desktop\gilectomy\PCbuild\xxlimited.vcxproj]
    c:\users\brian\desktop\gilectomy\include\lock.h(203): warning C4047: 'initializing': 'threadid_t' differs in levels of indirection from 'unsigned long (__cdecl *)()' [C:\Users\brian\Desktop\gilectomy
\PCbuild\xxlimited.vcxproj]
     ..\Modules\xxlimited.c(306): error C2129: static function 'void py_nativelock_unlock(void **)'     declared but not defined [C:\Users\brian\Desktop\gilectomy\PCbuild\xxlimited.vcxproj]
     c:\users\brian\desktop\gilectomy\include\lock.h(73): note: see declaration of 'py_nativelock_unlock'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants