Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all supported props to prop types for the AjaxDynamicDataTable. #74

Open
JacobBrassington opened this issue Jul 23, 2019 · 3 comments

Comments

@JacobBrassington
Copy link
Contributor

Currently in the DynamicDataTable we have all of the supported props being in the prop types object. However in the AjaxDynamicDataTable we only have a few of them with the rest being spread but not in the prop types.

I think it would be useful to add all supported props to the prop types to allow users to get type hinting when using this component.

@dextermb
Copy link
Contributor

However in the AjaxDynamicDataTable we only have a few of them with the rest being spread but not in the prop types.

This is because props get spread onto the DynamicDataTable which means every prop supposed by the base data table is supported by the AJAX table.

Currently the AJAX table is not documented, which is should be, but until recently was not used much and was still under testing.

I think it would be useful to add all supported props to the prop types to allow users to get type hinting when using this component.

I definitely agree with this, perhaps merging prop types might be the way around this.

@dextermb dextermb changed the title Add all supported props to prop types. Add all supported props to prop types for the AjaxDynamicDataTable. Jul 23, 2019
@JacobBrassington
Copy link
Contributor Author

However in the AjaxDynamicDataTable we only have a few of them with the rest being spread but not in the prop types.

This is because props get spread onto the DynamicDataTable which means every prop supposed by the base data table is supported by the AJAX table.

This is what I said no?

@AlexCatch
Copy link

I think what @JacobBrassington is getting at is to specify the data tables props on prop types. I haven't looked at any code so forgive me if I'm wrong 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants