Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Extract Filter, Validator and ViewHelper into own packages #145

Open
marcelthole opened this issue Jan 9, 2025 · 3 comments
Open
Labels

Comments

@marcelthole
Copy link

RFC

Q A
Proposed Version(s) 3.0.0
BC Break? Yes

Goal

Reduce the dependencies for this package and focus only on the i18n component and split the additional Filters, Validators and ViewHelper into a separate package.

Background

The composer.json requires as dev dependency (don't know why as dev dependency) these packages:

  • laminas/laminas-filter
  • laminas/laminas-view
  • laminas/laminas-validator

But i only need the translation feature of this package and don't use the other mentioned laminas packages in the project.

Considerations

User have to add a additional composer package if they still want to use these Filters, Validators or ViewHelper.

Proposal(s)

Create 3 new packages

  • laminas/laminas-i18n-filter
  • laminas/laminas-i18n-viewhelper
  • laminas/laminas-i18n-validator

Move the code from this package to the new packages and also remove the dependency to the mentioned packages.
The new packages has only laminas-i18n and for example the laminas-filter dependency

@marcelthole marcelthole added the RFC label Jan 9, 2025
@froschdesign
Copy link
Member

The composer.json requires as dev dependency (don't know why as dev dependency) these packages:

In the past, a lot of work was done with soft dependencies.

Considerations

User have to add a additional composer package if they still want to use these Filters, Validators or ViewHelper.

Even if the technical considerations are correct: maintainers have even more repositories to maintain and to update. Please do not forget this!
Example: https://github.com/orgs/laminas/projects/37

@marcelthole
Copy link
Author

yeah that's true that this could be more work for the future if this package would be splittet. Thats the reason for this Ticket to discuss this or maybe to add it to your TSC Meeting :)

I'm open for every result. if it should be kept here i would create tasks to make them compatible to the latest versions 👍

@froschdesign
Copy link
Member

I hope for automation, then the number of repositories doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants