fix(BA-478): Accept container images that has the 'null' labels field in their manifests #3411
+70
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
force-pushed
the
fix/scanning-vanilla-local-images
branch
from
e339b75 to
733135e
Compare
achimnol
force-pushed
the
fix/scanning-vanilla-local-images
branch
from
733135e to
b9644cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3409 (BA-478)
This PR lets the container registry implementations coalesce
nullvalues in the manifest"labels"field to an empty dict to prevent breakage.It also adds explicit
typing.overridedecorators to mark overriden methods in theHarborRegistry_v2class. Though, we need a follow-up refactoring to make the code structure to tell the reader that: 'Harbor and Docker registry share the image manifest query and pull APIs while Harbor has its specific repository listing API.'This PR is a follow-up fix to #2582.
Checklist: (if applicable)