Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enums instead of Strings where possible values are known #13

Open
laanwj opened this issue Sep 6, 2018 · 1 comment
Open

Use enums instead of Strings where possible values are known #13

laanwj opened this issue Sep 6, 2018 · 1 comment
Labels
🪀 enhancement New feature or request

Comments

@laanwj
Copy link
Owner

laanwj commented Sep 6, 2018

The API could make more use of enums where the possible values are known; for example the addresstype parameter to newaddr, but also in returned structures. This has to be weighted against flexibility, though, in case the API is extended later.

@laanwj laanwj added the 🪀 enhancement New feature or request label Sep 6, 2018
@vincenzopalazzo
Copy link
Collaborator

vincenzopalazzo commented Jun 24, 2021

ack about this idea, I really love to have also a generic method to make some building blocks for the user to make a custom call for all the c-lightning methods.

This can be particularly useful when a user has some retro compatibility problem.

An example can be fn call_rpc(name_command: String, params: HashMap<String, Any>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪀 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants