Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't work with node 0.12 #3

Open
Trufi opened this issue Jul 29, 2015 · 3 comments
Open

Don't work with node 0.12 #3

Trufi opened this issue Jul 29, 2015 · 3 comments

Comments

@Trufi
Copy link

Trufi commented Jul 29, 2015

Hello. Looks like this module don't work with node 0.12. After npm install, following message appears in console:

gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Linux 3.13.0-53-generic
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /var/www/floors-convert/node_modules/clipper
gyp ERR! node -v v0.12.7
gyp ERR! node-gyp -v v2.0.1
gyp ERR! not ok 
npm ERR! Linux 3.13.0-53-generic
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "i"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the clipper package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls clipper
npm ERR! There is likely additional logging output above.
@kyleburnett
Copy link
Owner

I had not tested this before with v0.12. I'll look into this as soon as possible.

Thanks for reporting,
Kyle

@kyleburnett
Copy link
Owner

The issue, it turns out, is that the v8 engine introduced major changes from v0.10 to v0.12 of node.js including the method signature. To fix this, it looks like I need to use the module nan, which will take some time to integrate. This table represents the compatibility of node versions and corresponding clipper versions once 2.1.0 is released:

Node Version Clipper Version
0.10.x >= 1.0.0
0.12.x >= 2.1.0

@Trufi
Copy link
Author

Trufi commented Jul 30, 2015

Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants