Support update loading

[kunyan]

No description provided.

[aberonni]

What is this? Do you need help with it?

[kunyan]

@aberonni I'm thinking about using typescript rewrite this project, but before it, PR welcome to resolve this issue.

Busy with daily work :(

[aberonni]

I'd like to help but I don't understand what the issue is :) Il Mar 23 Mag 2017, 11:31 Kun Yan <[email protected]> ha scritto:

…

@aberonni <https://github.com/aberonni> I'm thinking about using typescript rewrite this project, but before it, PR welcome to resolve this issue. Busy with daily work :( — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABM7cr2r3SqFsOTCJ-uMu1z8HPyZCQLvks5r8qdegaJpZM4Mstlm> .

[hellofantastic]

I think what was meant by this is adding componentWillReceiveProps?
For my use case I needed to add that as my options come dynamically in from another object

componentWillReceiveProps(props) {
    if (this.state.options !== props.options) {
      this.state.options = this.convertOptions(props.options);
    }
  }

[engineersamuel]

@hellofantastic since objects are never strictly equal that componentWillReceiveProps will always result in the call to this.convertOptions. So yes, that will accomplish what you want, but it will also result in that convertOptions being called every time. Might as well not even do the equality check, or do a lodash isEqual which may not be worth it for performance, but there probably is very little perf impact anyway on such a small call.

[hellofantastic]

Riiiight of course , thanks for the insight

…

Sent from my iPhone

On Jul 2, 2017, at 5:10 AM, Samuel ***@***.***> wrote: @hellofantastic since objects are never strictly equal that componentWillReceiveProps will always result in the call to this.convertOptions. So yes, that will accomplish what you want, but it will also result in that convertOptions being called every time. Might as well not even do the equality check, or do a lodash isEqual which may not be worth it for performance, but there probably is very little perf impact anyway on such a small call. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.