From 5eef010acce2ac5f593eceac2511e1c526ed67f0 Mon Sep 17 00:00:00 2001 From: Bart Smykla Date: Tue, 21 Jan 2025 08:30:21 +0100 Subject: [PATCH] ci(gha): remove reference link from reviewers checklist comment (#12631) ## Motivation & Implementation information Removed the reference link from the reviewers checklist comment in `pr-modification.yaml`. The empty line before the link caused issues in automation that processes this workflow, breaking the comment format in the parent project. Signed-off-by: Bart Smykla --- .github/workflows/pr-modification.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pr-modification.yaml b/.github/workflows/pr-modification.yaml index 2165548dbce8..3494b13c8ca8 100644 --- a/.github/workflows/pr-modification.yaml +++ b/.github/workflows/pr-modification.yaml @@ -69,12 +69,10 @@ jobs: :mag: Each of these sections need to be checked by the reviewer of the PR :mag:: If something doesn't apply please check the box and add a justification if the reason is non obvious. - [ ] Is the PR title satisfactory? Is this part of a larger feature and should be grouped using `> Changelog`? - - [ ] PR description is clear and complete. It [Links to relevant issue][1] as well as docs and UI issues + - [ ] PR description is clear and complete. It [Links to relevant issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) as well as docs and UI issues - [ ] This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry) - [ ] IPv6 is taken into account (.e.g: no string concatenation of host port) - [ ] Tests (Unit test, E2E tests, manual test on universal and k8s) - Don't forget `ci/` labels to run additional/fewer tests - [ ] Does this contain a change that needs to be notified to users? In this case, [`UPGRADE.md`](../blob/master/UPGRADE.md) should be updated. - [ ] Does it need to be backported according to the [backporting policy](../blob/master/CONTRIBUTING.md#backporting)? ([this](https://github.com/kumahq/kuma/actions/workflows/auto-backport.yaml) GH action will add "backport" label based on these [file globs](https://github.com/kumahq/kuma/blob/master/.github/workflows/auto-backport.yaml#L6), if you want to prevent it from adding the "backport" label use [no-backport-autolabel](https://github.com/kumahq/kuma/blob/master/.github/workflows/auto-backport.yaml#L8) label) - - [1]: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword