Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Token for publishing bot to interact with GH repos #4434

Closed
sayanchowdhury opened this issue Sep 2, 2023 · 9 comments
Closed

Github Token for publishing bot to interact with GH repos #4434

sayanchowdhury opened this issue Sep 2, 2023 · 9 comments
Assignees

Comments

@sayanchowdhury
Copy link
Member

sayanchowdhury commented Sep 2, 2023

Organization or Repo

https://github.com/kubernetes/publishing-bot/

User affected

No response

Describe the issue

We are working on running publishing-bot as a periodic job on the test-infra [1]. The publishing-bot would be interacting with the Github repositories through a Github token. The idea is to create a secret with the token and deploy it in the k8s-infra-prow-build-trusted cluster.

The publishing bot is currently running in a cluster named aaa and this cluster already contains a secret publishing-bot-github-token which is a github token that has write access to the staging repositories.

We would like to know if the same token can be reused in the k8s-infra-prow-build-trusted cluster for running the publishing bot or should we file a request for a new token?

[1] kubernetes/publishing-bot#353

/cc @akhilerm

@ameukam
Copy link
Member

ameukam commented Sep 14, 2023

I don't see any issue on reusing the token in the aaa cluster. Let's get input from the Github admins.

cc @MadhavJivrajani @palnabarun @Priyankasaggu11929

@nikhita
Copy link
Member

nikhita commented Sep 22, 2023

I'm good with this. Let's wait until EOD for any blocking comments.

If there are none, please go ahead with this.

@nikhita nikhita self-assigned this Sep 22, 2023
@Priyankasaggu11929
Copy link
Member

I don't see any issue on reusing the token in the aaa cluster.

+1.

Just confirming, is this the only spot we're using the existing publishing-bot-github-token right now?

@MadhavJivrajani
Copy link
Contributor

+1 on reusing the token from the aaa cluster.

@mrbobbytables
Copy link
Member

+1 on reusing as well

@sayanchowdhury
Copy link
Member Author

@Priyankasaggu11929 Yes, this is only place the where the token is being used. @akhilerm Could you confirm this info once?

@ameukam
Copy link
Member

ameukam commented Oct 11, 2023

Token is available on the build cluster: kubernetes/k8s.io#5950

@sayanchowdhury
Copy link
Member Author

Thanks @ameukam. I go ahead and close this issue.

/close

@k8s-ci-robot
Copy link
Contributor

@sayanchowdhury: Closing this issue.

In response to this:

Thanks @ameukam. I go ahead and close this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants