Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default-Backend's ConfigMap should support binaryData #12730

Closed
mmueller-rs opened this issue Jan 20, 2025 · 2 comments
Closed

Default-Backend's ConfigMap should support binaryData #12730

mmueller-rs opened this issue Jan 20, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@mmueller-rs
Copy link

When deploying a Default-Backend, I want to be able to return an error of my style. For that, I'd like to be able to upload pictures (i.e. .png) via ConfigMap.
However, in the ConfigMap-Template, the data section is hardcoded without any option to specify binaryData which I would need to upload pictures.

My experience with Helm-Templating is limited, but maybe

data:
{{- with .data }}
{{- toYaml . | nindent 2 }}
{{- end }}
could be replaced with:

{{- with .data }}
data:
  {{- toYaml . | nindent 2 }}
 {{- end }}
{{- with .binaryData }}
binaryData:
  {{- toYaml . | nindent 2 }}
 {{- end }}

That way, if no binaryData is present, it should just skip it.

No

No

Kubernetes >= 1.10 is required, see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.10.md#apps

@mmueller-rs mmueller-rs added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented Jan 20, 2025

You can always deploy and configure a default backend on your own. The default backend provided by us is not meant to cover all possible use cases. It's rather a default implementation for the API we provide, but it's not meant to cover all use cases as we'd like to focus on the Ingress API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants