Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more hermetic tests #80

Open
1 task
Tracked by #73
liu-cong opened this issue Dec 9, 2024 · 4 comments
Open
1 task
Tracked by #73

Add more hermetic tests #80

liu-cong opened this issue Dec 9, 2024 · 4 comments
Assignees

Comments

@liu-cong
Copy link
Contributor

liu-cong commented Dec 9, 2024

Hermetic test is a fast way to verify functionality e2e without requiring an integration test env. In addition to the basic test we have today, we should add the following:

Test framework improvements:

  • Run a fake k8s API server so we don't need to fake the reconcilers
  • Verify metrics (not added yet)

Test Case

  • Test when model is not found in LLMService
  • Test when ModelServerPool is not found
  • Test when no backend pods are available
  • Test invalid request (e.g., doesn't contain "model")
  • Test backend server error, client should receive an error with an appropriate error code
  • Verify traffic split
  • Test algorithm
    • Sheddable request succeeds when resource is available; and dropped when resource is constrained
    • Verify min KV cache algo without LoRA
    • Verify LoRA affinity algo for the "warm up" case (when no pods has loaded any LoRA yet). This requires sending multiple requests and verify later requests will be sticky to backend pods.

Tasks

Preview Give feedback
@ahg-g
Copy link
Contributor

ahg-g commented Dec 16, 2024

Please take a look at integration test setup in jobset as an example: https://github.com/kubernetes-sigs/jobset/tree/main/test/integration/controller

@danehans
Copy link
Contributor

danehans commented Jan 6, 2025

I may not be able to add every requested test case but I can get this effort started.

/assign

@liu-cong
Copy link
Contributor Author

liu-cong commented Jan 6, 2025

@danehans thanks! Please sync with @BenjaminBraunDev as he started with some initial work. There are lot of tests to add so you can divide and conquer!

@danehans
Copy link
Contributor

danehans commented Jan 6, 2025

@liu-cong thanks for the heads-up. @BenjaminBraunDev can you provide a status update when you have a moment? Do you have a local branch or WIP PR that can be referenced to see how we can divide and conquer this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants