Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we configure multiple inference pools by reconciling InferencePool? #145

Open
Kuromesi opened this issue Jan 3, 2025 · 4 comments
Open

Comments

@Kuromesi
Copy link

Kuromesi commented Jan 3, 2025

Hello guys, I'm interested in this project and wondering why the inference pool is specified when starting up and only one pool can be defined? Is it intentionally or just convenient for poc? Can we configure multiple inference pools by reconciling InferencePool resource?

@danehans
Copy link
Contributor

danehans commented Jan 6, 2025

I'm new to the project, but I suspect the design approach focuses on a single use case that is supported by one InferencePool.

@Kuromesi
Copy link
Author

Kuromesi commented Jan 6, 2025

I'm new to the project, but I suspect the design approach focuses on a single use case that is supported by one InferencePool.

Thanks! I agree with that, maybe I could do some work to make some improvements on this so that we can define more pools and make it more flexible.

@ahg-g
Copy link
Contributor

ahg-g commented Jan 6, 2025

The APIs don't enforce a 1:1 extension to InferencePool relationship. The current reference implementation of the extension does make that assumption however, but this is more to start simple and also for sharding and scalability.

I don't believe that the ext-proc has to fundamentally be 1:1, so please feel free to make a proposal to change the code to support more than one InfernecePool. The key is to ensure that it scales well.

@Kuromesi
Copy link
Author

Kuromesi commented Jan 6, 2025

The APIs don't enforce a 1:1 extension to InferencePool relationship. The current reference implementation of the extension does make that assumption however, but this is more to start simple and also for sharding and scalability.

I don't believe that the ext-proc has to fundamentally be 1:1, so please feel free to make a proposal to change the code to support more than one InfernecePool. The key is to ensure that it scales well.

Got it, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants