Skip to content

Commit

Permalink
Fix missing external types in apply configurations
Browse files Browse the repository at this point in the history
Signed-off-by: Antonin Stefanutti <[email protected]>
  • Loading branch information
astefanutti committed Feb 10, 2025
1 parent ab98a5a commit e5d81f6
Show file tree
Hide file tree
Showing 9 changed files with 114 additions and 64 deletions.
17 changes: 17 additions & 0 deletions hack/update-codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,30 @@ kube::codegen::gen_helpers \
"${TRAINER_ROOT}/pkg/apis"

# Generate clients.
externals=(
"sigs.k8s.io/jobset/api/jobset/v1alpha2.JobSetSpec:sigs.k8s.io/jobset/client-go/applyconfiguration/jobset/v1alpha2"
"k8s.io/api/core/v1.EnvVar:k8s.io/client-go/applyconfigurations/core/v1"
"k8s.io/api/core/v1.EnvFromSource:k8s.io/client-go/applyconfigurations/core/v1"
"k8s.io/api/core/v1.ResourceRequirements:k8s.io/client-go/applyconfigurations/core/v1"
"k8s.io/api/core/v1.Toleration:k8s.io/client-go/applyconfigurations/core/v1"
"k8s.io/api/core/v1.Volume:k8s.io/client-go/applyconfigurations/core/v1"
"k8s.io/api/core/v1.VolumeMount:k8s.io/client-go/applyconfigurations/core/v1"
"k8s.io/api/autoscaling/v2.MetricSpec:k8s.io/client-go/applyconfigurations/autoscaling/v2"
)

apply_config_externals="${externals[0]}"
for external in "${externals[@]:1}"; do
apply_config_externals="${apply_config_externals},${external}"
done

echo "Generating clients for Kubeflow Trainer"
kube::codegen::gen_client \
--boilerplate "${TRAINER_ROOT}/hack/boilerplate/boilerplate.go.txt" \
--output-dir "${TRAINER_ROOT}/pkg/client" \
--output-pkg "${TRAINER_PKG}/pkg/client" \
--with-watch \
--with-applyconfig \
--applyconfig-externals "${apply_config_externals}" \
"${TRAINER_ROOT}/pkg/apis"

# Get the kube-openapi binary to generate OpenAPI spec.
Expand Down
35 changes: 22 additions & 13 deletions pkg/client/applyconfiguration/trainer/v1alpha1/containeroverride.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions pkg/client/applyconfiguration/trainer/v1alpha1/datasetconfig.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions pkg/client/applyconfiguration/trainer/v1alpha1/inputmodel.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 11 additions & 7 deletions pkg/client/applyconfiguration/trainer/v1alpha1/outputmodel.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 13 additions & 7 deletions pkg/client/applyconfiguration/trainer/v1alpha1/podspecoverride.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e5d81f6

Please sign in to comment.