Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types should include Status Reason/Condition #19

Closed
EItanya opened this issue Oct 13, 2023 · 3 comments · Fixed by #37
Closed

Types should include Status Reason/Condition #19

EItanya opened this issue Oct 13, 2023 · 3 comments · Fixed by #37
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@EItanya
Copy link
Contributor

EItanya commented Oct 13, 2023

Currently the Status Reason/Conditions are missing from the generated types. See RouteConditionReason and RouteConditionType. These are not directly referenced by the openapi schema because they are implicitly considered the String values you should use.

This is by no means a "requirement" as copying those types over is acceptable for now, but it would definitely be easier to implement this API if those types could also be generated somehow.

@shaneutt
Copy link
Member

Yes indeed, that sounds good.

Do you have a project actively using this library?

@EItanya
Copy link
Contributor Author

EItanya commented Oct 17, 2023

I do, but not quite ready for public consumption. Hoping to Open Source it in the next couple weeks!

@shaneutt shaneutt added the help wanted Extra attention is needed label Oct 17, 2023
@shaneutt shaneutt added this to the Initial Pre-Release milestone Oct 17, 2023
@shaneutt shaneutt added the enhancement New feature or request label Oct 17, 2023
@shaneutt
Copy link
Member

Heya @EItanya 👋

Just checking in! Wondering about your project, and your potential need for this feature?

@shaneutt shaneutt linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants