Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use treq for all requests #5

Open
ktdreyer opened this issue Jun 5, 2020 · 0 comments
Open

use treq for all requests #5

ktdreyer opened this issue Jun 5, 2020 · 0 comments
Labels
enhancement

Comments

@ktdreyer
Copy link
Owner

ktdreyer commented Jun 5, 2020 •
edited
Loading

Using twisted.web.xmlrpc.Proxy was helpful at first, but we're running into some limitations.

  1. We've had to override twisted.web.xmlrpc._QueryFactory to provide a custom marshaller that uses the <i8> XML-RPC extension.

  2. Simple HTTPS verification works in the latest Twisted versions (xmlrpc.Proxy performs no HTTPS certificate verification twisted/twisted#9836), but we still need TrustedProxy to 1) backport add that behavior to old Twisted versions and 2) support a custom CA location.

  3. There is no keepalive support, so performance suffers when making a ton of RPCs (eg. benchmarking). With treq we can pass twisted.web.client.HTTPConnectionPool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ktdreyer