Explicitly return false range values from DateTypes

kspurgin · Aug 21, 2024 · 645c6ce · 645c6ce
1 parent 58f11df
commit 645c6ce
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/lib/emendate/date_types/error.rb b/lib/emendate/date_types/error.rb
@@ -59,7 +59,7 @@ def earliest_at_granularity = nil
       # @return [NilClass]
       def latest_at_granularity = nil
 
-      # @return [NilClass]
+      # @return [FalseClass]
       def range? = false
 
       # @return [:invalid_date_type, :unprocessable_date_type,

diff --git a/lib/emendate/date_types/year.rb b/lib/emendate/date_types/year.rb
@@ -36,8 +36,9 @@ def validatable? = true
       def range?
         return false if range_switch == :before &&
           Emendate.options.before_date_treatment == :point
+        return true if partial_indicator || range_switch
 
-        true if partial_indicator || range_switch
+        false
       end
 
       private

diff --git a/lib/emendate/date_types/year_month.rb b/lib/emendate/date_types/year_month.rb
@@ -38,8 +38,9 @@ def validatable? = true
       def range?
         return false if range_switch == :before &&
           Emendate.options.before_date_treatment == :point
+        return true if partial_indicator || range_switch
 
-        true if partial_indicator || range_switch
+        false
       end
 
       private

diff --git a/lib/emendate/date_types/year_month_day.rb b/lib/emendate/date_types/year_month_day.rb
@@ -49,8 +49,9 @@ def literal = "#{year}"\
       def range?
         return false if range_switch == :before &&
           Emendate.options.before_date_treatment == :point
+        return true if range_switch
 
-        true if range_switch
+        false
       end
 
       private