Dict interface and Base interface adjustments #23
+1,193
−648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krynju
force-pushed
the
kr/dict-and-interface-adjustments
branch
from
e39975a to
a17ac6c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
===========================================
- Coverage 91.58% 76.92% -14.66%
===========================================
Files 4 6 +2
Lines 297 468 +171
===========================================
+ Hits 272 360 +88
- Misses 25 108 +83 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will probably take a while until its done, but I'm also doing a lot of breaking changes here, because as it turns out a lot of Base functions were either implemented incorrectly or not at all