Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

Skip connection inconsistency and AttributeError: 'FlexibleNeRFModel' object has no attribute 'linear_layers' #40

Open
BjoernHaefner opened this issue Jul 28, 2023 · 0 comments

Comments

@BjoernHaefner
Copy link

I guess in this line, linear_layers should be layers_xyz?

In a similar realm, I guess in this line you don't want a skip connection in the last layer? Then i != num_layers - 1 should be i != num_layers - 2, as the for-loop is in range(num_layers - 1) already? i will never be num_layers - 1, so it could happen that you have a skip-connection in the last layer of layers_xyz, e.g. if skip_connect_every=4 and num_layers=10. This should then throw an error in the forward call in this line. As there would be a dimension mismatch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant