Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session.post() with strong passwords #8

Open
pdath opened this issue Aug 14, 2022 · 7 comments
Open

session.post() with strong passwords #8

pdath opened this issue Aug 14, 2022 · 7 comments

Comments

@pdath
Copy link

pdath commented Aug 14, 2022

I tried to use a strong random RPC password, and it failed to create a valid URL for session.post().

For example, try using a password containing &. I suspect the parameters should be passed through something like urllib.parse.quote().

@kralverde
Copy link
Owner

ack, will look into

@kralverde
Copy link
Owner

sorry for the delay, could you confirm this works?

ce39621

@pdath
Copy link
Author

pdath commented Sep 9, 2022

I can confirm the patch works with strong passwords.

For the main documentation page, I also recommend adding the below command line argument for TeamRedMiner (it can go anywhere - I added it as the last parameter on my system):
--eth_hash_report=on ​
This causes TeamRedMiner to report its hash rate to the stratum proxy.

@pdath
Copy link
Author

pdath commented Sep 9, 2022

This is beta software and has only been tested on testnet.

ps. I have hit several blocks on the mainnet ...

@Seal-Clubber
Copy link
Contributor

#11 Opend a PR

@kralverde
Copy link
Owner

This is beta software and has only been tested on testnet.

ps. I have hit several blocks on the mainnet ...

awesome, could you let me know which blocks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants