Income from troops parked at temples results in a positive feedback loop

[neil-rutherford]

Overall, this is an awesome game and I really enjoy playing it! That being said, there is a bug with income calculation that affects gameplay.

Toward the end of the game, the last AI parks its troops at a temple, meaning that its troop count is included in the income calculation. It never moves its troops, meaning that it gets stuck in a [use troops to generate income] --> [use income to buy troops] --> [use troops to generate income] --> [...] positive feedback loop. After a few iterations of this, the AI is able to generate a stupid amount of money each turn and grow its army to an unrealistic size.

This affects gameplay because the AI army quickly becomes too large to defeat. If the player figures out how the AI is generating so much money, the player can grow their army the same way and eventually defeat the AI. (I had to look at your code to figure out what was going on.) Otherwise, the AI could either overrun the player or just be unbeatable. Every time the player mobilizes their troops away from a temple to attack the AI, they are putting themselves at a disadvantage (the troops are not at the temple, and are therefore not included in income calculations). Here's what my gameplay looks like now:

I'm not quite sure how to fix it, but I'd start at line 1982. Keep up the good work!