Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api_consistency_requirements_fp64 failing on device supporting fp64 #757

Open
rjodinchr opened this issue Jan 22, 2025 · 0 comments · May be fixed by #758
Open

api_consistency_requirements_fp64 failing on device supporting fp64 #757

rjodinchr opened this issue Jan 22, 2025 · 0 comments · May be fixed by #758

Comments

@rjodinchr
Copy link
Contributor

clvk has a conflict between what it exposes in CL_DEVICE_DOUBLE_FP_CONFIG and the cl_khr_fp64.

At the moment, cl_khr_fp64 is never exposed, while CL_DEVICE_DOUBLE_FP_CONFIG is not 0 when fp64 is supported.

I see two ways forward:

  1. Always return 0 when CL_DEVICE_DOUBLE_FP_CONFIG is queried
  2. Implement proper support for cl_khr_fp64:
    2.1 Expose cl_khr_fp64 when fp64 is supported
    2.2 Set CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE and CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE to something else that 0 when fp64 is supported

I would prefer solution 1 because as cl_khr_fp64 is never exposed at the moment, it means that the CTS is not testing clvk on fp64. Enabling those tests would add lots of work to pass CTS in the future.

rjodinchr added a commit to rjodinchr/clvk that referenced this issue Jan 22, 2025
@rjodinchr rjodinchr linked a pull request Jan 22, 2025 that will close this issue
rjodinchr added a commit to rjodinchr/clvk that referenced this issue Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant