Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a wrong in the agent.py? #40

Open
cvchanghao opened this issue Sep 3, 2020 · 1 comment
Open

Is there a wrong in the agent.py? #40

cvchanghao opened this issue Sep 3, 2020 · 1 comment

Comments

@cvchanghao
Copy link

cvchanghao commented Sep 3, 2020

Thanks for your working!
Maybe I found a mistake in your code. Can you check this?
distance_map = (feature_map-point_feature)**2
distance_map = torch.norm( distance_map, dim=1 ).view(real_batch_size, 1, self.p.grid_y*self.p.grid_x, self.p.grid_y*self.p.grid_x)

on line 203-204 in agent.py.
torch.norm() already compute the L2 norm of distance_map, there is no need to square the (feature_map-point_feature).

@koyeongmin
Copy link
Owner

Thank you! This is my mistake. In new version, the problem is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants