User friendly blockquote title #538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of the not so nice Github Alerts notations
mrueg
reviewed
Dec 17, 2024
| @@ -49,38 +49,38 @@ <h2 id="Simple-Blockquote">Simple Blockquote</h2> | |||
| <h2 id="GH-Alerts-Heading">GH Alerts Heading</h2> | |||
| <h3 id="Note-Type-Alert-Heading">Note Type Alert Heading</h3> | |||
| <ac:structured-macro ac:name="info"><ac:parameter ac:name="icon">true</ac:parameter><ac:rich-text-body> | |||
| <p>[!NOTE]</p> | |||
| <p> Note </p> | |||
There was a problem hiding this comment.
Can we remove the leading and trailing whitespaces on this?
There was a problem hiding this comment.
Thinking about it twice, why not remove the whole paragraph? It should show up in Confluence with the proper macro anyway. WDYT @prokod ?
mrueg
reviewed
Dec 17, 2024
| rightNode := node.NextSibling().(*ast.Text) | ||
|
|
||
| title := string(midNode.Value(source)) | ||
| sanitizedTitle := strings.Replace(strings.ToLower(title), "!", "", -1) |
There was a problem hiding this comment.
Instead of doing this on a character base, can we do it on a word base (i.e. look for the existing ghalerts with a [! in front and ] afterwards and then simply replace what you found?
|
Looking a bit further into it, I wonder if a Transformer might be the best to use: https://codeberg.org/forgejo/forgejo/src/branch/forgejo/modules/markup/markdown/callout/github.go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #537