Apply suggestions from code review

Co-authored-by: Andrew Lamb <[email protected]>
korowa · Jan 15, 2024 · 7adc667 · 7adc667
1 parent 879cd41
commit 7adc667
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/datafusion/physical-plan/src/joins/hash_join.rs b/datafusion/physical-plan/src/joins/hash_join.rs
@@ -990,7 +990,7 @@ impl RecordBatchStream for HashJoinStream {
 /// Executes lookups by hash against JoinHashMap and resolves potential
 /// hash collisions.
 /// Returns build/probe indices satisfying the equality condition, along with
-/// starting point for next iteration.
+/// (optional) starting point for next iteration.
 ///
 /// # Example
 ///

diff --git a/datafusion/physical-plan/src/joins/symmetric_hash_join.rs b/datafusion/physical-plan/src/joins/symmetric_hash_join.rs
@@ -863,8 +863,6 @@ pub(crate) fn join_with_probe_batch(
 /// * `random_state` - The random state for the join.
 /// * `null_equals_null` - A boolean indicating whether NULL values should be treated as equal when joining.
 /// * `hashes_buffer` - Buffer used for probe side keys hash calculation.
-/// * `probe_batch` - The second record batch to be joined.
-/// * `column_indices` - An array of columns to be selected for the result of the join.
 /// * `deleted_offset` - deleted offset for build side data.
 ///
 /// # Returns