Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ModelProvider so we don't have to manually add support #558

Open
JonahSussman opened this issue Jan 16, 2025 · 0 comments
Open

Change ModelProvider so we don't have to manually add support #558

JonahSussman opened this issue Jan 16, 2025 · 0 comments
Assignees
Labels
priority/nextup Issues we want to address soon rpc-server
Milestone

Comments

@JonahSussman
Copy link
Contributor

Right now, we have to add each provider manually, ex #557

We should probably think about doing something along the lines of dynamically looking up the class provided inside the langchain module instead of manually adding all these classes. Something like:

ModelClass = getattr(langchain, the_class_name)

One wrinkle is that some models come from different modules:

from langchain_aws import ChatBedrock
from langchain_community.chat_models import ChatOllama

So it needs to be slightly more clever than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/nextup Issues we want to address soon rpc-server
Projects
Status: No status
Development

No branches or pull requests

3 participants