Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to set analyzer configuration parameters #550

Open
sjd78 opened this issue Jan 15, 2025 · 0 comments
Open

Provide a way to set analyzer configuration parameters #550

sjd78 opened this issue Jan 15, 2025 · 0 comments
Labels
enhancement New feature or request rpc-server

Comments

@sjd78
Copy link
Member

sjd78 commented Jan 15, 2025

There are 5 analyzer configuration settings the IDE defines but have no passthrough via kai-rpc-server cli args or initialize request. They are:

  • incident limit
  • context lines
  • code snip limit
  • analyze known libraries
  • analyze dependencies

The first three are currently hardcoded:

kai/kai_analyzer_rpc/main.go

Line 77 in f1483fb

10000, 10, 10,

Please provide a reasonable way to pass along these parameters, or at least me know which ones should be enabled and which ones not.
@sjd78 sjd78 mentioned this issue Jan 15, 2025
Merged
sjd78 added a commit to konveyor/editor-extensions that referenced this issue Jan 15, 2025
@sjd78
🌱 Update config definitions, base configs and initialize call (#197)
adefc8c 
Based on changes to the kai runtime configurations in
konveyor/kai#526, update the CLI arguments and
initialize request object to match.

Summary of changes:
  - Reorder the config field definitions

  - Use enum values in config definitions where available

  - Config keys related to analyzer configuration still remain but cannot
    be passed along to the analyzer, see [kai issue 550](konveyor/kai#550)

  - Aligned CLI arguments and initialize request payload types to the
    updated Kai configuration keys

  - Dropped config.toml handling since that file is no longer in use

Prerequisite for: #184

---------

Signed-off-by: Scott J Dickerson <[email protected]>
@shawn-hurley shawn-hurley added enhancement New feature or request rpc-server labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request rpc-server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawn-hurley @sjd78