Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When analyzer-lsp-rpc does not start or stops, the kai rpc server should also stop #537

Open
shawn-hurley opened this issue Jan 7, 2025 · 7 comments
Assignees
Labels
bug Something isn't working priority/nextup Issues we want to address soon rpc-server
Milestone

Comments

@shawn-hurley
Copy link
Contributor

I don't know if this makes total sense, but if any of the component parts of the kai-RPC server are not running, I was wondering if it makes sense to stop the server as well.

@shawn-hurley shawn-hurley added bug Something isn't working rpc-server priority/nextup Issues we want to address soon labels Jan 10, 2025
@AdityaPandeyCN
Copy link
Contributor

Hi @shawn-hurley Can I work on this issue?

@shawn-hurley
Copy link
Contributor Author

@AdityaPandeyCN you sure can, let me know if you need any help.

I think that there is a way to raise an exception, and catch it in the main process that should work.

@shawn-hurley
Copy link
Contributor Author

@AdityaPandeyCN please let me know if you need any help or want to sync.

@AdityaPandeyCN
Copy link
Contributor

AdityaPandeyCN commented Jan 23, 2025

Thankyou for asking @shawn-hurley I am working on the approach where I raise an exception in the analyzer.py(https://github.com/konveyor/kai/blob/main/kai/analyzer.py) file on failure and catch this exception in the server.py(https://github.com/konveyor/kai/blob/main/kai/rpc_server/server.py) file as guided by you. what are your views on this approach?

@shawn-hurley
Copy link
Contributor Author

I think that the exception approach makes senses, can't wait to see it :)

@AdityaPandeyCN
Copy link
Contributor

Hi @shawn-hurley I have raised a PR with the discussed changes.

@shawn-hurley
Copy link
Contributor Author

@AdityaPandeyCN will attempt to to test this today and get back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/nextup Issues we want to address soon rpc-server
Projects
Status: No status
Development

No branches or pull requests

3 participants