-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] Support renaming a file - example with recommendation of changing persistence.xml file to application.properties #502
Comments
@pranavgaikwad
Can you send array of such objects instead of the current response?
|
Map solution response to internal format using only information from the provided diff. Main advantages: 1. automatically map files to corresponding diffs - apply/discard operations are file based and require single-file diff 2. allows incremental update to support add/delete/rename 3. file paths in git diffs are relative to repository root which usually maps to VS Code workspace Main disadvantage is increasing the dependency on the git diff format. Reference-Url: konveyor/kai#502 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Map solution response to internal format using only information from the provided diff. Main advantages: 1. automatically map files to corresponding diffs - apply/discard operations are file based and require single-file diff 2. allows incremental update to support add/delete/rename 3. file paths in git diffs are relative to repository root which usually maps to VS Code workspace Main disadvantage is increasing the dependency on the git diff format. Reference-Url: konveyor/kai#502 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@rszwajko Note that we have not talked about adding the rename feature yet for the mvp (probably won't). But from an api standpoint, this makes sense to me. |
I think that this is in the same vein as #218 and believe that they should become a single issue. We need to handle file operations as part of the output of an LLM (rename/remove) and (rename/update contents). Thoughts about repurposing one of these issues and re-naming to capture the fulll scope or can we create a tracking issue that links both of them. |
I agree, @shawn-hurley this is part of that bigger effort indeed |
This issue is tracking our ability to detect and execute when the LLM tells us that a given file should be renamed/moved.
For this specific example we would want to:
src/main/resources/application.properties
src/main/resources/application.properties
with entries derived from the oldersrc/main/resources/META-INF/persistence.xml
src/main/resources/META-INF/persistence.xml
See src/main/resources/META-INF/persistence.xml from coolstore sample and recommendation to change its contents and rename/move to application.properties
Note this is both rename AND move, as persistence.xml was under
src/main/resources/META-INF/
and we are moving up 1 directory, so no longer underMETA-INF
The text was updated successfully, but these errors were encountered: