Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect-assets could use cache checking to skip downloading assets that haven't been updated #334

Open
sjd78 opened this issue Jan 31, 2025 · 0 comments

Comments

@sjd78
Copy link
Member

sjd78 commented Jan 31, 2025

Specifically to help out developers, the collect-assets.js scripts could use basic caching HTTP headers to be able to skip downloading of any release assets (or workflow artifacts). If an asset hasn't been updated since the last download, skip the download.

ETag/If-None-Match headers could be used. The ETag would need to be stored and accessed in future (from our collect.json maybe?).

Last-Modified/If-Modified-Since request header on the asset fetch could be used. The If-Modified-Since header could be generated from the mtime of the previously downloaded file.

In either case, download could always be forced by removing the download_assets folder and running the script again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant