Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collect-assets to download kai assets from main branch / latest CI workflows #198

Closed
sjd78 opened this issue Jan 15, 2025 · 2 comments · Fixed by #194
Closed

Update collect-assets to download kai assets from main branch / latest CI workflows #198

sjd78 opened this issue Jan 15, 2025 · 2 comments · Fixed by #194
Assignees
Milestone

Comments

@sjd78
Copy link
Member

sjd78 commented Jan 15, 2025

Currently the collect-assets script only supports downloading kai binaries from released assets.

Two changes are needed.

First, to better support development cycles, the collect-assets scripts need to be able to download the kai assets from a workflow run on the more recent commit on the main branch of the kai repository.

Second, the current kai build will also include some of the assets we currently static keep in the repo under assets/. What ever assets can be downloaded from the kai builds should be and the local copy removed.

@sjd78
Copy link
Member Author

sjd78 commented Jan 21, 2025

I just noticed in https://github.com/konveyor/editor-extensions/actions/runs/12893802399/job/35951338229?pr=233#step:5:112 that if a release tag isn't found, the packaging process doesn't fail! Not finding a release need to be a fail.

Edit: Opened #235 to cover this.

@sjd78
Copy link
Member Author

sjd78 commented Jan 21, 2025

Note: #194 takes care of the first change.

Followup issues are required to

  1. replace static assets with downloading those assets packaged with kai (jdtls, jdtls bundles, seed rulesets, maven index file)
  2. make the collection/download fail if the target release/workflow run is not available

Edit: Opened #234 to cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants