Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEP-8 #2

Open
shorodilov opened this issue Jan 14, 2024 · 2 comments
Open

Fix PEP-8 #2

shorodilov opened this issue Jan 14, 2024 · 2 comments

Comments

@shorodilov
Copy link

if names != None and type(names) == dict:

Implementing type(s) checks this way violates PEP-8 rules and has code smells.
The more Python way to do the stuff is:

if isinstance(names, dict):
@komanch7
Copy link
Owner

Thanks for your rating and comment. I'll redo the project soon

@komanch7
Copy link
Owner

I'm sorry, I didn't have any free time. The link to the thread is below, I hope everything is fine with the code.
In any case, I will be glad to receive comments and tips.

https://github.com/komanch7/createusersdata/tree/1_Mutable_object_in_function_arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants