Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Duplicate filenames on the playlist #83

Open
druellan opened this issue Jan 10, 2018 · 9 comments
Open

Duplicate filenames on the playlist #83

druellan opened this issue Jan 10, 2018 · 9 comments

Comments

@druellan
Copy link

Hi! I'm having an issue with the 2.0.2 version of the component and Foobar 1.3.17

Seems that some mods are added twice to the playlist, for example:
2018-01-10_12h25_42
LIVING.zip

The MOD file plays OK, but since it is an old module from the DOS era that survived many HD, CAN have some kind of corruption in it. Anyway, perhaps some kind of extra-check while adding mods can be implemented to improve this?

Thanks!

@kode54
Copy link
Owner

kode54 commented Jan 10, 2018

Unplayed subsongs. Ignore or delete them if they're incorrect.

@druellan
Copy link
Author

Thanks for the reply. The problem is that on a long playlist they can become very annoying, or difficult to spot if you have only a couple of them. The "remove duplicates" command does not affect them.

I'm also testing OpenMPT with the same results:

2018-01-11_15h48_12

This two files are interesting. Both seems created using MilkyTracker, and they have a lot of subsongs in them
MilkyPlayer.zip

@kode54
Copy link
Owner

kode54 commented Jan 11, 2018

You can search for them with playlist search, using a query string which matches both %_subsong% greater than 0, and play time less than 10 seconds or so.

@SimonN
Copy link
Contributor

SimonN commented Jan 12, 2018

If kode54 considers this correct behavior of DUMB, maybe file the issue against Foobar?

Subsongs of 0 seconds, or even shorter than 10 seconds, look like technical artifacts rather than an intended subsong. But I can't make this judgement for kode54 because I know almost nothing about the module internals.

On the other hand, Shared Dig has 3 subsongs, all of length > 10 seconds, you might want those in the UI? First song is 2:xx long, all 3 subsongs together are 5:xx long.

@druellan
Copy link
Author

Another interesting one with more than 100 subsongs

badapple.zip

@druellan
Copy link
Author

druellan commented Jan 12, 2018

I'm still trying to find a legitimate use of the subsong, and I think it is something that must be related to the tracker more than the player itself, but again, I have no insight into this matter. The only thing I can state is that from a selection of more than 1.000 MODs from modarchive.org, several have subsongs, all of them leftovers that are not part of the song.

@druellan druellan reopened this Jan 12, 2018
@kode54
Copy link
Owner

kode54 commented Jan 12, 2018

It is related to a limited quantity of modules which legitimately contain playable music on unplayed orders.

@druellan
Copy link
Author

@kode54 ops! yes, posted the message incomplete by mistake, I've edited it.

@kode54
Copy link
Owner

kode54 commented Jan 12, 2018

For instance, Sphenx's Bubbles.it has leftovers that are a legitimate subsong, an unplayed region that is more than a minute long. It also decodes really slowly in foo_dumb, but reasonably fast in foo_openmpt.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants