Added 'get map' support to dump command #1216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @nitishmalang! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
hzxuzhonghu
reviewed
Feb 5, 2025
| kmeshctl dump <kmesh-daemon-pod> kernel-native | ||
|
|
||
| # Dual Engine mode: | ||
| kmeshctl dump <kmesh-daemon-pod> dual-engine |
There was a problem hiding this comment.
How about kmeshctl dump map?
I am thinking we should not require users to specify dual-engine or kernel-native, we can get it automatically
hzxuzhonghu
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddIng support for retrieving and displaying structured BPF map contents using the kmeshctl dump get map command.
Changes Introduced:
Introduced a new subcommand get map under kmeshctl dump to fetch and format BPF map data.
Parses raw uint32 and hexadecimal values into a structured JSON output.
Uses the existing port-forwarding logic to communicate with the Kmesh daemon.
Enhances debugging and observability for developers working with Kmesh BPF maps.
kmeshctl dump <kmesh-daemon-pod> get mapThis will return a structured JSON representation of the BPF map contents, making it easier to understand and debug.
References:
Closes #1117
Discussion: Issue #1117