Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New entrypoint script depends on Postgres being used #16

Open
mckennajones opened this issue Mar 7, 2024 · 3 comments · May be fixed by #17
Open

New entrypoint script depends on Postgres being used #16

mckennajones opened this issue Mar 7, 2024 · 3 comments · May be fixed by #17

Comments

@mckennajones
Copy link

Cool project! Small issue I ran into when setting it up:

This PR #14 introduced an entrypoint script that uses the pg_isready command to wait for a postgres DB to come up. But, the documentation mentions that you can use any Keyv backend. In fact, the readme uses redis as an example. So the entrypoint should probably check for the DB being ready in a more generic way.

@JannikStreek
Copy link
Member

@mckennajones uh thats right. As the dependencies are also connected to the chosen storage infrastructure, it might be best to prepare different or alternative docker files. I will think about it, thanks for raising this issue.

@squatica
Copy link

my 2 cents: the db container should have a healthcheck, and the storage container should depend on it. The healthcheck can then be different for redis or postgres.

@squatica squatica linked a pull request Mar 11, 2024 that will close this issue
@sakonn
Copy link

sakonn commented Jul 7, 2024

I was trying to deploy the container and got into the same issue since I want to use MySQL instead of Postgres. I have checked the pull request and seems fine to me. So, I would appreciate a new release with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants