Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkyReels Broken After Hunyuan I2V Update #425

Open
pftq opened this issue Mar 6, 2025 · 23 comments
Open

SkyReels Broken After Hunyuan I2V Update #425

pftq opened this issue Mar 6, 2025 · 23 comments

Comments

@pftq
Copy link

pftq commented Mar 6, 2025

Seems like the update for I2V broke something for SkyReels. I'm getting this error now:

HyVideoSampler
Given groups=1, weight of size [3072, 32, 1, 2, 2], expected input[2, 33, 49, 64, 64] to have 32 channels, but got 33 channels instead

@kijai
Copy link
Owner

kijai commented Mar 6, 2025

Are you on very latest version? I thought I fixed that earlier.

@pftq
Copy link
Author

pftq commented Mar 6, 2025

Let me check - I updated this morning for I2V.

@pftq
Copy link
Author

pftq commented Mar 6, 2025

Yeah I just updated and got the error again

@kijai
Copy link
Owner

kijai commented Mar 6, 2025

Yeah I just updated and got the error again

Updated how exactly? I just loaded the example workflow for Skyreels and it's working fine with the current code.

@pftq
Copy link
Author

pftq commented Mar 6, 2025

Through Comfyui custom nodes manager

Image
(I'm downgraded back down right now to finish a render)

@kijai
Copy link
Owner

kijai commented Mar 6, 2025

Manager has been notoriously annoying lately tbh.. maybe I need to bump the version again.

@pftq
Copy link
Author

pftq commented Mar 7, 2025

Works now

@pftq
Copy link
Author

pftq commented Mar 7, 2025

I'm getting this again but only on the latest fixed I2V model. It seems to be specific to the id fix, as the older i2v from yesterday doesn't trigger this error. I also have issues running their official github one which has model/weights mismatch error, so it's possible their model update itself is broken Tencent/HunyuanVideo-I2V#15 (comment)

HyVideoSampler
Given groups=1, weight of size [3072, 16, 1, 2, 2], expected input[1, 32, 31, 88, 156] to have 16 channels, but got 32 channels instead

@kijai
Copy link
Owner

kijai commented Mar 7, 2025

The fixed model doesn't work yet.

@pftq
Copy link
Author

pftq commented Mar 7, 2025

Ok good to confirm, thanks

@pftq
Copy link
Author

pftq commented Mar 7, 2025

What should be the i2vmode on Skyreels with the new update? It shows as disabled now on the old workflows.

Edit: Tried both and getting this error again on Skyreels.

HyVideoSampler

Given groups=1, weight of size [3072, 32, 1, 2, 2], expected input[2, 33, 7, 136, 240] to have 32 channels, but got 33 channels instead

@kijai
Copy link
Owner

kijai commented Mar 7, 2025

What should be the i2vmode on Skyreels with the new update? It shows as disabled now on the old workflows.

Edit: Tried both and getting this error again on Skyreels.

HyVideoSampler

Given groups=1, weight of size [3072, 32, 1, 2, 2], expected input[2, 33, 7, 136, 240] to have 32 channels, but got 33 channels instead

That should be fixed now, dynamic should be the old behaviour but stability should also work, no idea if it's good though.

@pftq
Copy link
Author

pftq commented Mar 7, 2025

Ok thanks - do you think you could default it to dynamic then for old workflows not to break? Would be helpful since it's a habit to drop in workflows from other MP4s and tweak from there.

@kijai
Copy link
Owner

kijai commented Mar 7, 2025

Ok thanks - do you think you could default it to dynamic then for old workflows not to break? Would be helpful since it's a habit to drop in workflows from other MP4s and tweak from there.

I don't think it makes a huge difference really... the default for the first I2V model would be same as stability, which is why I left that as default, but might make sense to be dynamic as it doesn't do anything extra.

@pftq
Copy link
Author

pftq commented Mar 7, 2025

No I mean as opposed to "disabled" being the default when an older workflow is pulled up. I'll probably forget at some point or other people might run into the same error and not realize it's from that being added as a field. Same with riflex - the default is "" even though it shows 0 on the GUI and throws an error on old workflows (has to be re-entered as 0 to fix).
Image

@kijai
Copy link
Owner

kijai commented Mar 7, 2025

No I mean as opposed to "disabled" being the default when an older workflow is pulled up. I'll probably forget at some point or other people might run into the same error and not realize it's from that being added as a field. Same with riflex - the default is "" even though it shows 0 on the GUI and throws an error on old workflows (has to be re-entered as 0 to fix). Image

Oh yeah that was an oversight, changed it to "dynamic" now. RifleX already was 0 and always has been though, but ComfyUI gets all kinds of messed up with node updates still...

@pftq
Copy link
Author

pftq commented Mar 7, 2025

Great, thanks

@pftq
Copy link
Author

pftq commented Mar 8, 2025

Skyreels broken again after i2v-fix working. I checked and redownloaded the wrapper as well via git clone. I am reverting back to 1.05 for now (last working version for Skyreels)

HyVideoSampler
Given groups=1, weight of size [3072, 32, 1, 2, 2], expected input[2, 33, 49, 64, 64] to have 32 channels, but got 33 channels instead

@kijai
Copy link
Owner

kijai commented Mar 8, 2025

Skyreels broken again after i2v-fix working. I checked and redownloaded the wrapper as well via git clone. I am reverting back to 1.03 for now (last working version for Skyreels)

HyVideoSampler
Given groups=1, weight of size [3072, 32, 1, 2, 2], expected input[2, 33, 49, 64, 64] to have 32 channels, but got 33 channels instead

Are you sure? Nothing has changed about that since I fixed it, and it still works for me with current code.

@pftq
Copy link
Author

pftq commented Mar 8, 2025

Yeah - it worked on 1.0.5, then updating to 1.0.6 (latest) gets the error. Also while on the subject, I think if you add a case for accepting "" as input being the same as 0, that'll give backwards compatibility to old workflows without throwing an error. It's a silent error otherwise so it's a bit insidious.
https://youtu.be/z0YdACfQeic

@kijai
Copy link
Owner

kijai commented Mar 8, 2025

Yeah - it worked on 1.0.5, then updating to 1.0.6 (latest) gets the error. Also while on the subject, I think if you add a case for accepting "" as input being the same as 0, that'll give backwards compatibility to old workflows without throwing an error. It's a silent error otherwise so it's a bit insidious. https://youtu.be/z0YdACfQeic

Latest on manager isn't actually latest code though, should be on nightly for that.

Updated the version and added fallback to check if riflex index is a string.

@pftq
Copy link
Author

pftq commented Mar 8, 2025

Ok I'll try again later today thanks

@pftq
Copy link
Author

pftq commented Mar 9, 2025

Still getting this. On nightly 1.07. Edit: nvm got it working finally with uninstall + git clone

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants