Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Implement a "Feed" of downloaded videos #504

Closed
robertkleinschuster opened this issue Dec 11, 2024 · 3 comments · Fixed by #508
Closed

[FR] Implement a "Feed" of downloaded videos #504

robertkleinschuster opened this issue Dec 11, 2024 · 3 comments · Fixed by #508
Assignees

Comments

@robertkleinschuster
Copy link
Contributor

robertkleinschuster commented Dec 11, 2024

It would be nice to have a dedicated view that displays basically the same as the Media History but filtering out not downloaded videos.

This could then be used as a feed to watch videos directly in Pinchflat. I think the video detail view is already quite nice and it is a shame that it is a bit hidden away.

Bildschirmfoto 2024-12-11 um 18 31 31 Bildschirmfoto 2024-12-11 um 21 32 53
@kieraneglin
Copy link
Owner

I dig it! This would fit in well with #478

I see you're working on something in your fork - I'd maybe recommend to hold off for a bit because I'd like to look into a bit of a refactor for how I'm handling tables in general. I'll let you know when/if I end up making those changes!

@robertkleinschuster
Copy link
Contributor Author

I first didn’t quite understand what was meant with #478 but now i see what you are going for.

I saw that there’s a bit of duplicate code but I think it’s OKish at the moment for what it is.

When touching this more broadly I would also recommend moving away from “real” html tables as they are kind of a pain on mobile. Rather design some responsive layout that folds out and expands on desktop.

In the long run it might be an idea having a general media item view which can be initialized with different filters and sorting options.

But I think that’s a bit out of scope here. If I’m motivated enough, i might look into it.

@kieraneglin
Copy link
Owner

In the long run it might be an idea having a general media item view which can be initialized with different filters and sorting options.

This is, ideally, the end goal of my refactor. A generalized system for tables where you just have to provide methods for how to fetch/sort/filter data and it does the rest. I'm not sure whether I'll be able to fully realize that, but I'm sure I can make a better system than what currently exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants