Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Naming Inconsistency in Templates #266

Open
3 tasks
ItsAnkan opened this issue Oct 30, 2024 · 1 comment
Open
3 tasks

File Naming Inconsistency in Templates #266

ItsAnkan opened this issue Oct 30, 2024 · 1 comment
Labels
clean code Lint, consistency and prettifying of code easy stuff Good for newcomers, or if you want to do something quick

Comments

@ItsAnkan
Copy link
Member

ItsAnkan commented Oct 30, 2024 •
edited by Jx-ls
Loading

The template naming under the src/templates folder is inconsistent as of now, some uses hyphens( - ) and some uses underscore( _ ).

Things to be done:

  • Rename all the files to use hyphens instead. (As we are using hyphens in the URLs)
  • Change the folder templates/govportal to templates/gov-portal.
  • Change govportal/govportal.njk to gov-portal/_gov_portal.njk. (Since all the boilerplates start with underscores( _ ))

When you make these changes, you are also required to reflect these changes where these file paths are used (for eg, in routes, etc)
@ItsAnkan ItsAnkan added easy stuff Good for newcomers, or if you want to do something quick clean code Lint, consistency and prettifying of code labels Oct 30, 2024
@Goose-Of-War
Copy link
Member

govportal/govportal.njk to gov-portal/_gov_portal.njk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean code Lint, consistency and prettifying of code easy stuff Good for newcomers, or if you want to do something quick
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Goose-Of-War @ItsAnkan