Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): utilize CLDR ABNF rules to validate transforms #13175

Open
srl295 opened this issue Feb 10, 2025 · 0 comments · May be fixed by #13236
Open

feat(developer): utilize CLDR ABNF rules to validate transforms #13175

srl295 opened this issue Feb 10, 2025 · 0 comments · May be fixed by #13236
Assignees
@srl295
Labels
developer/ epic-ldml feat
Milestone
B18S1

Comments

@srl295
Copy link
Member

srl295 commented Feb 10, 2025

CLDR now has ABNF rules for transform from= and to= rules.

Use these to validate at the developer side that valid strings are being used.
@srl295 srl295 added this to the B18S1 milestone Feb 10, 2025
@srl295 srl295 self-assigned this Feb 10, 2025
srl295 added a commit that referenced this issue Feb 13, 2025
@srl295
chore(resources): import ABNF from CLDR v47
928e8e3 
- update fetch-latest-cldr.sh - so next time, abnf will get updated.
- note, this is abnf from 47 but we’re not doing the full 47 import yet because it's not released.

Fixes: feat(developer): utilize CLDR ABNF rules to validate transforms #13175
srl295 added a commit that referenced this issue Feb 13, 2025
@srl295
feat(core): output keyman_core_ldml.sh
5b264bc 
- refactor const generator
- output as .sh also
- use variable instead of fixed 46

Fixes: #13175
srl295 added a commit that referenced this issue Feb 13, 2025
@srl295
feat(core): convert abnf to peggy grammar
422c436 
- convert each .abnf to a .pegjs file

Fixes: #13175
srl295 added a commit that referenced this issue Feb 13, 2025
@srl295
feat(developer): use peggy grammar in from/to transform
ebc7bb8 
Fixes: #13175
@srl295 srl295 linked a pull request Feb 13, 2025 that will close this issue
Draft
srl295 added a commit that referenced this issue Feb 14, 2025
@srl295
chore(resources): import ABNF from CLDR v47
98b1fac 
- update fetch-latest-cldr.sh - so next time, abnf will get updated.
- note, this is abnf from 47 but we’re not doing the full 47 import yet because it's not released.

Fixes: feat(developer): utilize CLDR ABNF rules to validate transforms #13175
srl295 added a commit that referenced this issue Feb 14, 2025
@srl295
feat(core): convert abnf to peggy grammar
a2a0e79 
- convert each .abnf to a .pegjs file

Fixes: #13175
srl295 added a commit that referenced this issue Feb 14, 2025
@srl295
feat(developer): use peggy grammar in from/to transform
53b20e6 
Fixes: #13175
srl295 added a commit that referenced this issue Feb 14, 2025
@srl295
feat(developer): update builder for abnf
2e842bc 
- just convert over all abnf (as we do with copying imports)
- hard coded CLDR version number for now

Fixes: #13175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
developer/ epic-ldml feat
Projects
Keyman
Status: No status
Milestone
B18S1
Development

Successfully merging a pull request may close this issue.

feat(developer): use ABNF to validate LDML transform keymanapp/keyman
1 participant
@srl295