Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radiusOfInnerMostHit could be removed from Track #319

Closed
tmadlener opened this issue Jun 18, 2024 · 6 comments · Fixed by #326
Closed

radiusOfInnerMostHit could be removed from Track #319

tmadlener opened this issue Jun 18, 2024 · 6 comments · Fixed by #326
Labels
discussion Discussion item

Comments

@tmadlener
Copy link
Contributor

The Track currently has a member radiusOfInnerMostHit, which could be removed, as it is technically easily computable from the attached TrackerHits. The only / main(?) reason to keep it would be to keep this information around even if the TrackerHits are dropped (as is the case for example in DSTs for ILD).

@tmadlener tmadlener added the discussion Discussion item label Jun 18, 2024
@gaede
Copy link
Collaborator

gaede commented Jun 19, 2024

We (BH, JMC, FG) believe that this should be droped. (If really needed later, adding it is easy w/ schema evolution).

@Zehvogel
Copy link
Contributor

This was quite useful information on DST files (no-hits) imo...

@tmadlener
Copy link
Contributor Author

Removing it for now, since it's mixing analysis and reconstruction level quantities too much. We have a similar discussion for other items, e.g. #322

@tmadlener tmadlener moved this from Todo to Ready for review in EDM4hep v1.0 Jun 28, 2024
@tmadlener tmadlener moved this from Ready for review to Draft / In Progess in EDM4hep v1.0 Jun 28, 2024
@tmadlener tmadlener moved this from Draft / In Progess to Ready for review in EDM4hep v1.0 Jul 3, 2024
@github-project-automation github-project-automation bot moved this from Ready for review to Done in EDM4hep v1.0 Jul 8, 2024
@farakiko
Copy link

farakiko commented Nov 26, 2024

Hi, I was looking into computing the radiusOfInnerMostHit because I need to use this variable for particle flow reconstruction. Since I have access to events generated with a previous software build that still has access to SiTracks_Refitted/SiTracks_Refitted.radiusOfInnermostHit, I was trying to confirm my piece of code below:

zzz 13

Unfortunately, it seems that my piece of code is not correct because it does not match the value directly obtained from the branch SiTracks_Refitted/SiTracks_Refitted.radiusOfInnermostHit

Could you perhaps share how to build this variable from the other branches? Thanks!

@andresailer
Copy link
Collaborator

Dear @farakiko

Please open a new issue, and please don't screenshoot text, but give us the actual code as text so we don't have to potentially type things ourselves.

Thanks,
Andre

@farakiko
Copy link

farakiko commented Nov 26, 2024

Thank you! Submitted the issue #384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion item
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants