Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaccard loss #341

Closed
innat opened this issue Apr 12, 2022 · 12 comments
Closed

Jaccard loss #341

innat opened this issue Apr 12, 2022 · 12 comments
Assignees

Comments

@innat
Copy link
Contributor

innat commented Apr 12, 2022

Another useful loss function for semantic segmentation tasks. It was available in keras-contrib, losses/jaccard.py

@innat innat mentioned this issue Apr 18, 2022
@qlzh727
Copy link
Member

qlzh727 commented Apr 18, 2022

If I understand the jaccard correctly, it is like IoU metric in keras-team/keras. In that sense, we might just add it to keras repo, since usually metric and loss just share the same backend function.

@bhack
Copy link
Contributor

bhack commented Apr 18, 2022

@bhack
Copy link
Contributor

bhack commented Apr 18, 2022

I meant is it ready now for Keras? As if It was in contrib it was not accepted in Keras at that time.

@qlzh727
Copy link
Member

qlzh727 commented Apr 18, 2022

The IoU metric is in keras-team/keras at https://github.com/keras-team/keras/blob/9e8bd934b088b4724221520828146a358609caa6/keras/metrics/metrics.py#L2568. If the jaccard loss is same/similar as IoU metric, then I think it might be fit for keras-team/keras. @fchollet

@bhack
Copy link
Contributor

bhack commented Apr 18, 2022

Ok in that case I suppose that we can move the issue between repos under the same org, or not?

@qlzh727
Copy link
Member

qlzh727 commented Apr 18, 2022

I think the issue can be moved between repos in the same org

@qlzh727 qlzh727 transferred this issue from keras-team/keras-cv Apr 18, 2022
@sushreebarsa sushreebarsa assigned qlzh727 and unassigned sushreebarsa Apr 19, 2022
@innat
Copy link
Contributor Author

innat commented Apr 19, 2022

@qlzh727 It would be great to have this loss function from core keras. But as it's mostly cv-related loss function, isn't it fitter to have it from keras_cv; if cv-related stuff moves to keras_cv from keras in the future? Also, if we have Dice loss from keras_cv and Jaccard loss from keras, it might be a confusing UX, IM0.

@qlzh727
Copy link
Member

qlzh727 commented Apr 19, 2022

I will check with API owner for this question, and see where we want to place this loss. Will update later this week.

@bhack
Copy link
Contributor

bhack commented Apr 19, 2022

Just for the record: keras-team/keras-contrib#533

@qlzh727 qlzh727 transferred this issue from keras-team/keras Apr 21, 2022
@qlzh727
Copy link
Member

qlzh727 commented Apr 21, 2022

Moved back to keras-cv. I think we would like this to be more cv specific, eg for bounding box etc. We will keep this in keras-cv for now, until we feel there are generic use case support in core keras. (based on the discussion we have within keras-team.)

@qlzh727
Copy link
Member

qlzh727 commented Apr 21, 2022

Feel free to send PR to keras-cv/losses.

@innat innat mentioned this issue May 20, 2022
@LukeWood
Copy link
Contributor

The KerasCV team is attempting to narrow the package scope in order to more efficiently use our limited resources. As such, we are only accepting contributions directly related to items on the 6 month roadmap for the package.

If you feel this feature could be particularly useful, or would like to contribute it - please feel free to re-open this issue and ping LukeWood, ianstenbit or tanzhenyu

Feel free to read more on the roadmap:
https://github.com/keras-team/keras-cv/blob/master/.github/ROADMAP.md

@LukeWood LukeWood reopened this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants