Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vApplicationIdleHook() cannot be overridden. #56

Open
derekmulcahy opened this issue Jan 16, 2020 · 0 comments
Open

vApplicationIdleHook() cannot be overridden. #56

derekmulcahy opened this issue Jan 16, 2020 · 0 comments

Comments

@derekmulcahy
Copy link

  • [x ] BUG REPORT

The vApplicationIdleHook() is defined in freertos/lib/osentry.c as

void vApplicationIdleHook(void)
{
}

better code would be

#if ( configUSE_IDLE_HOOK == 1 )
void __attribute__((weak)) vApplicationIdleHook(void)
{
}
#endif /* configUSE_IDLE_HOOK */

as this would allow the application to implement the hook and it would not define the hook unless it is needed. I have tested this and it works well.

@minux minux changed the title vApplicationHook() cannot be overridden. vApplicationIdleHook() cannot be overridden. Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant