Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Comickfun causes slowdowns, always returns LIMIT results. #7543

Closed
7 tasks done
mm12 opened this issue Feb 7, 2025 · 1 comment
Closed
7 tasks done
Labels
Bug Bugs in existing sources

Comments

@mm12
Copy link

mm12 commented Feb 7, 2025

Source information

all.comickfun 1.4.52

Source language

All

Steps to reproduce

  1. Install comick, pin source
  2. Perform a few migrations or searches. No need to open comick, it just needs to show the results.
  3. Each of these you do adds 20 DB entries. This causes slowdowns in the app (noticeable stuttering while scrolling) over time. If a user were to perform many migrations (say, a source shut down), this would cause issues very quickly. You can see this in mainApp/settings/advanced/clear database.

Expected behavior

  1. Comik should return close matches, up to some limit
  2. It should do this in a reasonable timeframe

Actual behavior

  1. Comik returns as many matches as it can (20), even if the search is dissimilar to the result.
  2. Comik runs much slower than other sources.

Mihon/Tachiyomi version

0.17.1

Android version

Android 15

Other details

Background: this line sets the limit to 20, however it always returns 20 results. Lowering this number may help to remedy the issue, but does not address the root of the problem.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.15.3.
  • I have updated all installed extensions.
  • I have tried the troubleshooting guide.
  • If this is an issue with the app itself, I should be opening an issue in the app repository.
  • I will fill out all of the requested information in this form.


Add a 👍 reaction to issues you find important.

@mm12 mm12 added the Bug Bugs in existing sources label Feb 7, 2025
@AwkwardPeak7
Copy link
Contributor

mihonapp/mihon#1594

@AwkwardPeak7 AwkwardPeak7 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Bugs in existing sources
Projects
None yet
Development

No branches or pull requests

2 participants