Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README file would benefit from more detail #38

Open
K4kap0 opened this issue Apr 11, 2022 · 4 comments
Open

README file would benefit from more detail #38

K4kap0 opened this issue Apr 11, 2022 · 4 comments

Comments

@K4kap0
Copy link
Contributor

K4kap0 commented Apr 11, 2022

I don't have a lot of experience in this sort of area and probably because of that have had troubles with installing and using the code in this repositority. Perhaps including more detailed usage and installation instructions would be helpful.

@keflavich
Copy link
Owner

If you have a specific question, please ask. The README is only meant to provide minimalist documentation; you should read the real documentation that is linked from the README for more details.

@lukfd
Copy link

lukfd commented Sep 23, 2022

@keflavich I would also like to mention that the web page https://image-registration.readthedocs.io/en/latest/#quick-example presents the code

from image_registration import chi2_shift from image_registration.fft_tools import shift xoff, yoff, exoff, eyoff = chi2_shift(image, offset_image, noise, ... return_error=True, upsample_factor='auto') corrected_image2 = shift.shiftnd(offset_image, -yoff, -xoff)

Should it be corrected_image2 = shift.shiftnd(offset_image, (-yoff, -xoff))

Thanks!

@keflavich
Copy link
Owner

Good catch @lukfd . Actually, that example is correct already:
https://github.com/keflavich/image_registration/blob/21f5a5359a41d52199fc175407a011bd411630e3/docs/index.rst#quick-example
but it looks like the docs aren't building. I'll look into it.

@keflavich
Copy link
Owner

Docs are building, so @lukfd your issue should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants