Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve redemption request proposal event deduplication #3698

Closed
pdyraga opened this issue Aug 11, 2023 · 2 comments
Closed

Improve redemption request proposal event deduplication #3698

pdyraga opened this issue Aug 11, 2023 · 2 comments

Comments

@pdyraga
Copy link
Member

pdyraga commented Aug 11, 2023

The deduplicator for redemption proposal events takes into account redeemer output script and redemption TX fee:

var buffer bytes.Buffer
buffer.Write(newProposal.WalletPublicKeyHash[:])
for _, script := range newProposal.RedeemersOutputScripts {
buffer.Write(script)
}
buffer.Write(newProposal.RedemptionTxFee.Bytes())

If the given redeemer is the only one redeeming for the last few hours and the Bitcoin TX fee estimation did not change, the redemption proposal for the second (valid!) redemption request will be ignored as a duplicate.

One possible option to fix this could be to shorten the caching period for this particular event. There may be better solutions but I can't think of any right now.

@erdogan
Copy link
Collaborator

erdogan commented Sep 18, 2023

@lukasz-zimnoch, this was opened by Piotr but did not have an owner. Temporarily tagging you here, feel free to reassign or deprioritize if this is not urgent

@lukasz-zimnoch lukasz-zimnoch removed their assignment Nov 6, 2023
@lukasz-zimnoch
Copy link
Member

No longer relevant due to: keep-network/tbtc-v2#737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants